fix: add resource strings for file selection #31881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #31854
In Electron 16, we refactored the file select helper for file dialogs, but we also need to include the strings in our resource bundle for the description ids for custom file types and media files. This PR adds those strings to electron_resources and uses
electron_resources.h
rather than Chrome'sgenerated_resources.h
.Checklist
npm test
passesRelease Notes
Notes: Fixed a potential crash when importing media files or custom file types.